-
Notifications
You must be signed in to change notification settings - Fork 32
Previous version links on document pages with mapped entries in front matter #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ous versions of the current doc
…on docs-assembler.
…of a document if provided by the front matter, and concrete implementations
… it, and use during HTML rendering
…sion_disclaimer' into feature/frontmatter_previous_version_disclaimer
Mpdreamz
requested changes
Mar 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few nitpicks about how HistoryMapper
flows through the object graph.
…ted into HtmlWriter instead of a BuildContext property, and adjust legacyUrl nomenclature
Mpdreamz
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles #865
As I was working on it, I found a couple of mapped pages set incorrectly, and sent PRs on the way of the repositories. Running locally works (once manually fixed for now, that is)
As the mapping file is acquired by docs-assembler, checking out the results locally requires builder's serve-static.
Prerequisites: